-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns prefix and suffix on wrapper #3502
base: main
Are you sure you want to change the base?
Conversation
Note to self: we also talked about adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a possible error. Also, this needs a complementary PR to the 4.2 docs, before we merge it.
[ci skip] [skip ci]
Bump! @promatik do you still think this is worth doing? |
The inspection completed: No new issues |
Quick note, this highlights an inconsistency between the place of the column prefix and suffix, inside or outside the wrapper. In some fields column prefix/suffix are inside, others are outside. But, that is a breaking change, so not for now 🤷♂️ |
Docs here Laravel-Backpack/docs#389 🙌 |
@promatik if you think this is still worth doing, please add v6 docs for it (instead of v5) then ask Pedro to review and merge. |
@pxpm updated docs to v6 Laravel-Backpack/docs#389 👌 |
Related with #3435.
This adds ability to add prefix and suffix to each column wrapper.